Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to use newer cimg images and go version #497

Merged
merged 3 commits into from Dec 22, 2022
Merged

Update CI to use newer cimg images and go version #497

merged 3 commits into from Dec 22, 2022

Conversation

jesusvazquez
Copy link
Member

This PR does two things:

  • Update circleci images to use the new cimg/go and cimg/ruby images instead of the deprecated circleci/... ones.
  • Updates go mod to make carbon-relay-ng a go 1.18 project.

@jesusvazquez jesusvazquez self-assigned this Dec 21, 2022
@jesusvazquez
Update gitignore
a28e660 
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
@jesusvazquez
Bump go mod go version to 1.18
205d8b3 
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
@jesusvazquez
Update images to use official circleci images
aa3c996 
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
alexgreenbank
alexgreenbank approved these changes Dec 21, 2022
View reviewed changes
Copy link

@alexgreenbank alexgreenbank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusvazquez jesusvazquez merged commit 03e446d into master Dec 22, 2022
@jesusvazquez jesusvazquez deleted the jvp/update-go-mod branch December 22, 2022 11:03
@fionaliao fionaliao mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgreenbank alexgreenbank alexgreenbank approved these changes

@ywwg ywwg Awaiting requested review from ywwg

@fionaliao fionaliao Awaiting requested review from fionaliao

Assignees

@jesusvazquez jesusvazquez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jesusvazquez @alexgreenbank