Parse string input for params of type Integer or Float #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
npazosmendez
reviewed
Sep 9, 2022
| } | ||
| } | ||
|
|
||
| func TestDoGetIntArg(t *testing.T) { |
There was a problem hiding this comment.
We could add some tests for the regular (previously supported) cases too, now that we have tests for this (also for Float)
This comment has been minimized.
This comment has been minimized.
carrieedwards
force-pushed
the
cedwards/allow-string-ints-floats
branch
from
851db46
to
7bdc8a4
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
carrieedwards
changed the title
carrieedwards
added a commit
that referenced
this pull request
Sep 14, 2022
* Parse strings as ints or floats for params of type Integer or Float * Add parser tests * Fix failing e2e test
npazosmendez
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Parse strings as ints or floats for params of type Integer or Float * Add parser tests * Fix failing e2e test
npazosmendez
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Parse strings as ints or floats for params of type Integer or Float * Add parser tests * Fix failing e2e test
npazosmendez
pushed a commit
that referenced
this pull request
Sep 16, 2022
…-floats-ints Parse string input for params of type Integer or Float (#106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the float and int parsing functions to be able to parse string input. If the param type is a string, it will attempt to use strconv.ParseFloat or strconv.ParseInt and if the string can be converted to a float, that float value will be used. This will allow more leniency for users input, and be more consistent with Graphite web. Graphite web's parsing of floats and strings can be found here