Consolidate series by step for divideSeries #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
expr/helper/align.go
Outdated
| @@ -379,6 +379,21 @@ func ScaleSeries(args []*types.MetricData) []*types.MetricData { | |||
| return args | |||
| } | |||
|
|
|||
| func ConsolidateSeriesByStepForDivision(numerator, denominator *types.MetricData) (*types.MetricData, *types.MetricData) { | |||
There was a problem hiding this comment.
Nit: perhaps change the name of this, as in seriesList functions we are using it for not just division, but multiply, diff, pow, etc. I would suggest 'ConsoliateSeriesListsByStep' or something along those lines
carrieedwards
approved these changes
Sep 13, 2022
leizor
force-pushed
the
leizor/aligned-divide-series
branch
from
28305e7
to
e194d74
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the fix in #99 to
divideSeries.