Improve summarization tests with from and until parameters #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters for tests
carrieedwards
force-pushed
the
cedwards/improve-summarization-tests
branch
from
ffd5b77
to
e4449d8
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
leizor
pushed a commit
that referenced
this pull request
May 24, 2023
Update summarization test helper to allow for using from and until parameters for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SummarizeEvalTestItem and TestSummarizeEvalExpr to allow from a From and Until value to be used for the evaluation of a query. This affects hitcount, smartSummarize, and summarize tests, which have been updated to include the From and Until fields in each test case. These functions can alter the start and/or end time of the data being pulled if alignToInterval (hitcount), alignTo (smartSummarize) and alignToFrom (summarize) are set in the query. This update to the tests allows us to test that the alterations of the start and/or end time are updated properly.