Align smartSummarize results stop time to the upper limit of the final bucket #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
npazosmendez
approved these changes
Apr 25, 2023
leizor
pushed a commit
that referenced
this pull request
May 24, 2023
…l bucket (#140) * Set results stop time to the final bucket's upper bound * Test alignment of results stop time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in smartSummarize in which the stop time of the results was not aligned to the upper bound of final bucket. If the stop time of the series is smaller than the final bucket's upper bound, the stop time of the resulting series should be set to that final bucket's upper bound.
This fix is mimicking the behavior found in Graphite web's version of smartSummarize; see here and here, where the resulting series's end is set to the timestamp returned by _summarizeValues().