Update spacing in removeBelowSeries assignment of name to match Graphite web #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -70,9 +69,9 @@ func (f *removeBelowSeries) Do(ctx context.Context, e parser.Expr, from, until i | |||
| } | |||
|
|
|||
| r := a.CopyLink() | |||
| r.Name = e.Target() + "(" + a.Name + "," + numberStr + ")" | |||
| r.Name = e.Target() + "(" + a.Name + ", " + fmt.Sprintf("%d", int(number)) + ")" | |||
There was a problem hiding this comment.
Is the int conversion correct? GraphiteWeb seems to be using the float directly https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/functions.py#L3601
There was a problem hiding this comment.
That's fair. I can change it back to a float
This comment has been minimized.
This comment has been minimized.
carrieedwards
force-pushed
the
cedwards/fix-removeBelowSeries-name
branch
from
fcc6799
to
7669b3a
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the spacing in removeBelowSeries assignment of name in MetricData to include a space between the series name and number threshold. This is to match Graphite web's assignment of name for the results for removeBelowSeries.