Use ExtractMetric for name parsing in aliasByMetric and sumSeriesWithWildcards #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
|
Can we get a test for this? Mainly as a form of documentation of the decision made |
npazosmendez
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
I see how this fixes our issue, but I'm not sure if this fix is OK for carbonapi itself. It looks like the error is coming from us constructing a MetricData instance erroneously; AFAIU if we were using MakeMetricData(..) this would work as expected.
I'm approving because I think it's no big deal (but the upstream may not agree)
|
It should also help with trimming out parentheses and such if a series name is set to something along the lines of |
|
And in the case of sumSeriesWithWildcards, it is consistent with how aggregateSeriesWithWildcards does it. |
That's handled by
We implemented |
|
From what I could see, MakeMetricData is only called from tests currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates aliasByMetric and sumSeriesWithWildcards to use ExtractMetric to grab the name of the metric instead of using the name tag. Since some functions set the name of the series as the function name + series name, using the name tag to get the metric name could cause metrics with parentheses in them. ExtractMetric parses out parentheses properly, preventing this issue.