Add handling for '+' char in metric names in queries #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
As we discussed with @carrieedwards, we want to wait to merge our changes to the upstream before including this fix. This is because we are not sure about the impact of this change to other backends that are not mimir, so this might be a relevant change for the upstream that we don't want to hide in a huge PR. |
leizor
reviewed
Sep 8, 2022
| target: "foo.b[0-9]+.qux", | ||
| etype: EtName, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Is there a way for us to be explicit about what the expression will result with? I think since this is somewhere we're choosing to diverge from graphite-web we should strive to be as clear as possible what we're doing.
npazosmendez
force-pushed
the
cedwards/fix-regexp-handling
branch
from
02613ff
to
bcc6684
Compare
|
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
|
We've decided we are merging this to our fork because we consider it necessary at this point. We will be sending this PR to the upstream later and have the maintainers opinions/feedback . |
npazosmendez
approved these changes
Sep 21, 2022
npazosmendez
pushed a commit
that referenced
this pull request
Sep 21, 2022
Add handling for + char in metric names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error we were seeing in which including a '+' symbol as part of a regular expression in a metric name was resulting in an error being thrown. For example:
alias(testMetric[0-9]+.Metric, 'name')
throws an error of:
unexpected character.The Graphite docs on wildcard expressions do not explicitly mention the '+' character as unsupported, it does not throw an error and seems to process it. Therefore, this PR aims to make parsing more consistent with Graphite web.