-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert module identity change #94
Conversation
This comment has been minimized.
This comment has been minimized.
Go coverage report: Click to expand.
Go lint report: No issues found. 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are a couple of references to grafana/carbonapi that are in comments and just referring to issues we have filed, but I think its fine to leave those. We could eventually file those issues in the upstream repo and changes the references then.
When we started this fork, we renamed the module from
github.com/go-graphite/carbonapi
togithub.com/grafana/carbonapi
. We changed our minds because:These are the commits reverted:
And some extra fixes were needed after those reverts.