Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quote table names with dots #298

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Feb 10, 2023

I used @chenlujjj's commit as an example, though I opted for double-quote instead of a backtick to be compatible with pgsql-ast-parser library that is used in ast.ts, and added a couple more unit tests.

@slvrtrn slvrtrn requested a review from a team as a code owner February 10, 2023 16:04
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@bossinc bossinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bossinc bossinc merged commit bb2773e into grafana:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DESC TABLE expression not work when table name contains dot
4 participants