Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to 9.4.3 using @grafana/create-plugin #328

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Mar 21, 2023

  • Address build deprecation warning and migrate using @grafana/create-plugin tools
  • Bump all main @grafana libraries from 8.5.11 to 9.4.3
  • Add missing tslib dependency
  • Address breaking changes in the tests - mainly handle async user events and add waitFor when necessary to prevent React's "overlapping act() calls" warnings
  • Address changes in Jest's behavior in validate.test.ts
  • Use Grafana 9.4.3 and ClickHouse 23.2 in docker-compose
  • Fix a few typos

@slvrtrn slvrtrn requested a review from a team as a code owner March 21, 2023 14:27
@gingerwizard
Copy link
Collaborator

Spoke with @slvrtrn and completely understand why he wants to bump these but this will break support for 8.x users.
We have a few options:

  1. Create a 2.x branch and move main to 3.x. Moving forward we maintain both. Only 2.x supports 8.x. We backport where possible. We now incur a maintenance overhead until 10.x grafana is released.
  2. We push this change until 10.x is released. @bossinc any timeline on this? this will block some improvements.
  3. We accept that 8.x users will not be supported and release 3.x. 2.x is not maintained.

package.json Show resolved Hide resolved
@bossinc
Copy link
Collaborator

bossinc commented Mar 21, 2023

@gingerwizard Grafana 10 will release in June.

We can create a v2 branch as you suggested, but it would only be worth doing if there are plans to use features from create-plugin before June. If not, we can park this PR until 10 is released.

Here is a form post explaining the release support lifecycle

@gingerwizard
Copy link
Collaborator

@bossinc there are. We want to support Explore histograms. Please create a v2 branch.

@bossinc bossinc merged commit 567ef5c into grafana:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants