String for complex types except traces #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bossinc let me know once the new sqlds is released and ill repush. |
gingerwizard
changed the title
bossinc
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #329 we changed the converted for complex types like Tuple and Arrays to raw.JSONMessage. This allows the trace view to work.
However, this means JSON messages e.g. in logs, are rendered incorrectly.
We ideally want to conditionally encode to JSON string based on the preferedVisualizationType i.e. use json.RawMessage for traces but string elsewhere.
This PR handles server side using
MutateResponse. Depends on grafana/sqlds#89