Add initial feature tracking #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aangelisc
previously approved these changes
Apr 4, 2023
asimpson
approved these changes
Apr 6, 2023
aangelisc
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened:
The goal of this task is to add feature tracking to CH so we can get more information on how much certain features are used. This PR adds initial tracking for the type of queries (SQL vs Builder) and if a builder query is used what format is selected (Table, Aggregate or Time Series). With this information we can determine what how much certain features are used. If they are not, we can remove them from the code base, if they are we can improve its UX so they are easier to use.
This is the list of things we can track so far:
Query editor:
Format: I assume a big percentage of queries will use the "Table" format, since it is the default. We will track how many builder queries use "Table", "Aggregate" or "Time Series".
Builder vs SQL editor: How much is the raw (SQL) editor used?
Closes #339