Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing in candlestick and heatmap schemas #292

Open
K-Phoen opened this issue Mar 18, 2024 · 0 comments
Open

Incorrect parsing in candlestick and heatmap schemas #292

K-Phoen opened this issue Mar 18, 2024 · 0 comments
Labels
area:parsers bug Something isn't working

Comments

@K-Phoen
Copy link
Member

K-Phoen commented Mar 18, 2024

In candlestick:

CandlestickColors: {
	up:   string | *"green"
	down: string | *"red"
	flat: string | *"gray"
}

Options: {
	colors: CandlestickColors | *{
		down: "red"
		up:   "green"
		flat: "gray"
	}
	// ...
}

Seems to be parsed as:

CandlestickColors: {
	up:   string | *"green"
	down: string | *"red"
	flat: string | *"gray"
}

Options: {
	colors: {
		down: "red"
		up:   "green"
		flat: "gray"
	}
	// ...
}

See: https://github.com/grafana/grafana-foundation-sdk/blob/8b681f9a0094f787fb0f6691b8c24aa60c5ecfef/typescript/src/candlestick/types.gen.ts#L66-L70

A similar problem seems to occur in the heatmap schema with the HeatmapOptionsLegend and HeatmapOptionsExemplars definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:parsers bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant