Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix incorrectly parsed type for heatmap.Options.tooltip #300

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

K-Phoen
Copy link
Member

@K-Phoen K-Phoen commented Apr 2, 2024

Similar to #293

Relates to #292

@K-Phoen K-Phoen self-assigned this Apr 2, 2024
@K-Phoen K-Phoen requested a review from a team as a code owner April 2, 2024 10:19
Copy link

github-actions bot commented Apr 2, 2024

Note: in addition to the changes introduced by this PR, the diff includes unreleased changes living in main.

🔎 Changes to grafana-foundation-sdk@next+cog-v0.0.x

diff --git a/go/heatmap/panel_builder_gen.go b/go/heatmap/panel_builder_gen.go
index c16e0e6..832682a 100644
--- a/go/heatmap/panel_builder_gen.go
+++ b/go/heatmap/panel_builder_gen.go
@@ -566,11 +566,6 @@ func (builder *PanelBuilder) applyDefaults() {
 	builder.Legend(HeatmapLegend{
 		Show: true,
 	})
-	builder.Tooltip(HeatmapTooltip{
-		Mode:           "single",
-		ShowColorScale: cog.ToPtr[bool](false),
-		YHistogram:     cog.ToPtr[bool](false),
-	})
 	builder.ExemplarsColor(ExemplarConfig{
 		Color: "rgba(255,0,255,0.7)",
 	})
diff --git a/typescript/package.json b/typescript/package.json
index 98b609c..b583d87 100644
--- a/typescript/package.json
+++ b/typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grafana/grafana-foundation-sdk",
-  "version": "next-cogv0.0.x.1711456284",
+  "version": "next-cogv0.0.x.1712053196",
   "description": "A set of tools, types and libraries for building and manipulating Grafana objects.",
   "keywords": [
     "observability",
diff --git a/typescript/src/heatmap/types.gen.ts b/typescript/src/heatmap/types.gen.ts
index 848fb76..a6c60a0 100644
--- a/typescript/src/heatmap/types.gen.ts
+++ b/typescript/src/heatmap/types.gen.ts
@@ -188,7 +188,7 @@ export const defaultOptions = (): Options => ({
 	cellGap: 1,
 	yAxis: defaultYAxisConfig(),
 	legend: { show: true, },
-	tooltip: { mode: common.TooltipDisplayMode.Single, yHistogram: false, showColorScale: false, },
+	tooltip: defaultHeatmapTooltip(),
 	exemplars: { color: "rgba(255,0,255,0.7)", },
 });
 

@K-Phoen K-Phoen merged commit 9b4d0ba into main Apr 2, 2024
10 checks passed
@K-Phoen K-Phoen deleted the fix/heatmap-tooltip branch April 2, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant