-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup imports management in Python #304
base: main
Are you sure you want to change the base?
Conversation
Note: in addition to the changes introduced by this PR, the diff includes unreleased changes living in
grafana-foundation-sdk@next+cog-v0.0.x |
It is indeed sorted by the import name, but that's not the standard python way to sort imports Here's an example of how it should be sorted (as
It's sorted: type of import -> import lib -> imported symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting to remove the review request (posted my previous comment in the wrong place) 😄. Re-request review when ready!
Mostly some renamings, to make the imports management more understandable.
Imports are also now sorted, to ensure a reproducible output