OpenAPI: Add discriminators #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Phoen
reviewed
Oct 17, 2023
| @@ -59,6 +59,7 @@ func CompilerPasses() []compiler.Pass { | |||
| return []compiler.Pass{ | |||
| &compiler.Unspec{}, | |||
| &compiler.DashboardPanelsRewrite{}, | |||
| &compiler.PrefixEnumValues{}, | |||
There was a problem hiding this comment.
Why do we need that for typescript? 🤔
There was a problem hiding this comment.
Because I saw the same problem with the integer enums and they are setting number as names and they are invalid.
There was a problem hiding this comment.
Then I think we should probably have a different compiler pass, specifically for that use-case :)
There was a problem hiding this comment.
This one is working as expected... what is the difference?
K-Phoen
reviewed
Oct 17, 2023
K-Phoen
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: #58
It adds discriminators for
oneOfandanyOffor OpenAPI.allOfwill be in other PR since it needs refactor of references to be able to point to external files.