Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ingester storage class configurable #368

Open
fculpo opened this issue Aug 6, 2021 · 3 comments
Open

Make ingester storage class configurable #368

fculpo opened this issue Aug 6, 2021 · 3 comments

Comments

@fculpo
Copy link

fculpo commented Aug 6, 2021

Hello,

The storage class for ingester is hardcoded to 'fast'

Could we make this configurable ?

@pracucci
Copy link
Collaborator

pracucci commented Aug 6, 2021

When you use the blocks storage it's already configurable via cortex_ingester_data_disk_class (ingester pvc is overridden in tsdb.libsonnet). If you're using the chunks storage, then yes, you can open a PR to use cortex_ingester_data_disk_class in ingester.libsonnet too.

@fculpo
Copy link
Author

fculpo commented Aug 6, 2021

Sorry but I don't see where/how to pass this value.
The field does not exist in config.libsonnet and I don't see where tsdb.libsonnet is called from cortex.libsonnet

@pracucci
Copy link
Collaborator

The field does not exist in config.libsonnet and I don't see where tsdb.libsonnet is called from cortex.libsonnet

If you run the blocks storage, then you have to import tsdb.libsonnet explicitly after cortex.libsonnet. If you don't do it, then I guess you're running the (old and deprecated) chunks storage, so I would suggest you the following:

If you're using the chunks storage, then yes, you can open a PR to use cortex_ingester_data_disk_class in ingester.libsonnet too.

You can define cortex_ingester_data_disk_class in config.libsonnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants