Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rules testing a la promtool test rules <test file>.yml #159

Open
genebean opened this issue Mar 11, 2021 · 1 comment
Open

Implement rules testing a la promtool test rules <test file>.yml #159

genebean opened this issue Mar 11, 2021 · 1 comment

Comments

@genebean
Copy link

The fix for #148 does not account for promtool test rules <test file>.yml. Please also fix that since the namespace bits break the upstream tool.
@freddd
Copy link

freddd commented Nov 26, 2021

+1, we recently upgraded promtool and was hit with the same issue. This PR: prometheus/prometheus#7767 was the one that broke promtool for us since it's now doing strict validation and not allowing namespace.

friedrichg pushed a commit to cortexproject/cortex-tools that referenced this issue Aug 1, 2023
@nschad
cut 0.5.0 release (grafana#159)
9e530ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@genebean @freddd