Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit if --remote-read-path incorrect #260

Closed
Dentrax opened this issue Sep 26, 2022 · 0 comments · Fixed by grafana/mimir#3053
Closed

Exit if --remote-read-path incorrect #260

Dentrax opened this issue Sep 26, 2022 · 0 comments · Fixed by grafana/mimir#3053

Comments

@Dentrax
Copy link

Dentrax commented Sep 26, 2022 •
edited
Loading 

$ cortextool remote-read stats --address http://10.11.12.13:30090 --selector '{__name__!=""}'

INFO[0000] Created remote read client using endpoint 'http://10.11.12.13:30090/prometheus/api/v1/read'
INFO[0000] Querying time from=2022-09-26T11:02:20+03:00 to=2022-09-26T12:02:20+03:00 with selector={__name__!=""}

$ echo $?
0

http://10.11.12.13:30090/prometheus/api/v1/read returns 404.

I'd expect an exit 1 and fatal log here, but it returns success instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(remote-read): return err instead of nil Dentrax/mimir
1 participant
@Dentrax