Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] cortextool alertmanager get does not output valid YAML #263

Closed
justinTM opened this issue Oct 11, 2022 · 1 comment
Closed

[BUG] cortextool alertmanager get does not output valid YAML #263

justinTM opened this issue Oct 11, 2022 · 1 comment

Comments

@justinTM
Copy link
Contributor

Steps to reproduce:

$ cortextool alertmanager get | yq .
Error: bad file '-': yaml: control characters are not allowed
@justinTM
Copy link
Contributor Author

use --disable-color:

$ cortextool alertmanager get --disable-color | yq .
  # They are grouped by product and environment rather than cluster
  # and alertname.
  routes:
    - receiver: 'teams-webhook-test2'
      group_by: [product, environment]
      matchers:
        - team="frontend"
Templates:

friedrichg pushed a commit to cortexproject/cortex-tools that referenced this issue Aug 1, 2023
@jmcarp
Disable ingester liveness probes by default. (grafana#263)
3415984 
Based on cortex docs at
https://cortexmetrics.io/docs/guides/running-cortex-on-kubernetes/#take-extra-care-with-ingesters,
liveness probes for ingesters are not recommended: "We do not recommend
configuring a liveness probe on ingesters - killing them is a last resort and
should not be left to a machine."

Signed-off-by: Josh Carp <jm.carp@gmail.com>
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this issue Aug 1, 2023
@jmcarp
Disable ingester startup probe by default. (#286)
489979b 
Following up on grafana#263, we should disable ingester startup probes by
default, since the cortex docs note that killing ingesters "should not
be left to a machine". I've also noticed restart loops due to the
startup probe when starting ingesters after downtime, when remote
writers have a backlogs of metrics to send.

Signed-off-by: Josh Carp <jm.carp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinTM