Allow parsing rules from a byte slice. #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Apr 30, 2021
gotjosh
approved these changes
Apr 30, 2021
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ Order should be `CHANGE`, `FEATURE`, `ENHANCEMENT`, and `BUGFIX` | |||
|
|
|||
| ## unreleased/master | |||
|
|
|||
| * [ENHANCEMENT] Expose method `rules.ParseBytes` to allow parsing rules from a byte slice. | |||
There was a problem hiding this comment.
I'd say remove this changelog entry as this is not a user-visible change.
gouthamve
approved these changes
Apr 30, 2021
The rule parser currently allows reading rules from file(s). Parsing a byte slice (which was removed as part of #80) might still be useful to some users.
cristiangreco
force-pushed
the
rules-parse-bytes
branch
from
71dfdea
to
7f70395
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
The rule parser currently allows reading rules from file(s). Parsing a byte slice (which was removed as part of grafana/cortex-toolshttps://github.com/grafana/cortex-tools/pull/80) might still be useful to some users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule parser currently allows reading rules from file(s). Parsing a
byte slice (which was removed as part of #80) might
still be useful to some users.