Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blockgen command to generate blocks of mock data #191

Merged
merged 10 commits into from
Jun 15, 2021
Merged

Add blockgen command to generate blocks of mock data #191

merged 10 commits into from
Jun 15, 2021

Conversation

replay
Copy link
Contributor

@replay replay commented Jun 11, 2021

No description provided.

@replay
successfully generating blocks
3548386 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
simplify and cleanup
07e89e8 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
add docs
8e595d6 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
undo unnecessary change
b065b97 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
cleanup
81ba085 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
undo unnecessary changes
7efdbba 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
undo unnecessary changes
63a6512 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay requested a review from jtlisi June 11, 2021 22:39
@replay replay requested a review from a team as a code owner June 11, 2021 22:39
bboreham
bboreham reviewed Jun 12, 2021
View reviewed changes
Copy link

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

However there is a compile error - is something missing?

@replay
fix test
c41089f 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
linter fix
cca72ea 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay
Copy link
Contributor Author

replay commented Jun 13, 2021

Nice!

However there is a compile error - is something missing?

Hey, thanks for checking it out!
Sorry about that, I forgot to commit a change in a test file.
The CI is passing now

jtlisi
jtlisi approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/commands/block_gen.go Outdated Show resolved Hide resolved
@replay
allow user to configure replicas
ddeff29 
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
@replay replay merged commit b7df2d4 into main Jun 15, 2021
@replay replay deleted the blockgen branch June 15, 2021 15:16
@simonswine simonswine mentioned this pull request Jan 7, 2022
Merged
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
@replay
Add blockgen command to generate blocks of mock data (grafana/cortex-…
4c97353 
…tools#191)

Generate blocks of mock data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham left review comments

@jtlisi jtlisi jtlisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@replay @jtlisi @bboreham