Update grafana-tools/sdk to latest version #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hjet! Which binary is this affecting? |
|
hey @gotjosh!! my bad, requested a review by accident before this was ready to go 🙃 i will add more context when it's ready for review, but tldr for now is it affects both
will add the failure case here before pinging for review |
|
@gotjosh updated PR description, let me know if any questions |
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
…rafana#192) Signed-off-by: Arjun Bhandage <abhandage@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cortextool analyse grafanafails on certain dashboards that use templating and/or panel heights due to unmarshalling errors with the underlying grafana-tools/sdk library. Notably, the command fails on kubernetes-mixin dashboards.See grafana-tools/sdk#130 for an example failure case and gist containing dashboards (same error).
grafana-tools/sdk#141 fixes the panel height issue and grafana-tools/sdk#151 (just merged) fixes the templating issue.
This PR updates the library to point to latest master to capture these fixes.
cc @devinrcheevers @gouthamve