-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyse ruler #201
Merged
Merged
Add analyse ruler #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add metrics extraction from dashboard & rules files
owen-d
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed, but LGTM
It'd be great to have an example output in the README |
Good call, will add |
gouthamve
approved these changes
Aug 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
…s#201) Adds the following: analyse ruler analyse dashboards (JSON dashboard input) analyse rule-files (YAML rule file input) Modifies analyse prometheus to accept input from analyse ruler and analyse rule-file output Fixes a bug to iterate over sub panels of a row type Panel Adds two simple tests for extracting metrics Adds metric extraction from templating sections of dashboard files
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
…a#201) Signed-off-by: Tom Hayward <thayward@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analyse ruler
analyse dashboards
(JSON dashboard input)analyse rule-files
(YAML rule file input)analyse prometheus
to accept input fromanalyse ruler
andanalyse rule-file
outputrow
type Paneltemplating
sections of dashboard files(note) Also see grafana-tools/sdk#159 which fixes a deserializing error for the
Decimals
field that I discovered (this is an existing bug, not a new one)