Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyse ruler #201

Merged
merged 12 commits into from
Aug 6, 2021
Merged

Add analyse ruler #201

merged 12 commits into from
Aug 6, 2021

Conversation

hjet
Copy link
Contributor

@hjet hjet commented Jul 29, 2021

  • Adds the following:
    • analyse ruler
    • analyse dashboards (JSON dashboard input)
    • analyse rule-files (YAML rule file input)
  • Modifies analyse prometheus to accept input from analyse ruler and analyse rule-file output
  • Fixes a bug to iterate over sub panels of a row type Panel
  • Adds two simple tests for extracting metrics
  • Adds metric extraction from templating sections of dashboard files

(note) Also see grafana-tools/sdk#159 which fixes a deserializing error for the Decimals field that I discovered (this is an existing bug, not a new one)

@hjet hjet changed the title [WIP] Add analyse ruler Add analyse ruler Aug 3, 2021
@hjet hjet marked this pull request as ready for review August 3, 2021 19:46
@hjet hjet requested a review from a team as a code owner August 3, 2021 19:46
@hjet hjet requested a review from gouthamve August 3, 2021 19:46
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed, but LGTM

@owen-d
Copy link
Member

owen-d commented Aug 5, 2021

It'd be great to have an example output in the README

@hjet
Copy link
Contributor Author

hjet commented Aug 5, 2021

It'd be great to have an example output in the README

Good call, will add

Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjet hjet merged commit 9a6f025 into main Aug 6, 2021
@hjet hjet deleted the add_analyse_ruler branch August 6, 2021 20:16
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
…s#201)

Adds the following:
analyse ruler
analyse dashboards (JSON dashboard input)
analyse rule-files (YAML rule file input)

Modifies analyse prometheus to accept input from analyse ruler and analyse rule-file output
Fixes a bug to iterate over sub panels of a row type Panel
Adds two simple tests for extracting metrics
Adds metric extraction from templating sections of dashboard files
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
…a#201)

Signed-off-by: Tom Hayward <thayward@infoblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants