Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2ealerting] Support pass through labels & custom histogram buckets #202

Closed
wants to merge 7 commits into from

Conversation

callumj
Copy link

@callumj callumj commented Aug 4, 2021

We're using e2ealerting across our k8s fleet to monitor latency from ingestor to AM and want to be able to break that down by specific tags like cluster name or AZ. We could solve this by generating one rule for each but this becomes harder to manage as our cluster grows automatically. Instead this adds the ability to pass through custom labels from AM to the histogram and improves the timestamp seen logic to track this by the particular facets.

It also provides customization for the histogram buckets for those that want to get more granular on specific details.

@callumj callumj requested a review from a team as a code owner August 4, 2021 00:32
@gotjosh
Copy link
Collaborator

gotjosh commented Aug 6, 2021

Hi @callumj thank you very much for your contribution! This is gladly something we can bake into e2ealerting.

I started to review this but found the changes a bit hard to follow all at once, do you mind if we split this PR into smaller increments so that we can work together?

From what I can see we have three changes:

  1. Configurable Histogram Buckets
  2. Healthcheck endpoint
  3. Support tracking of custom labels

It'd be my preference if we can start with 1/2 and then move into 3. This tool is quite sensitive to changes given it's nature and I want to make sure we get it right from the get go 🙏

@callumj callumj closed this Aug 6, 2021
@callumj
Copy link
Author

callumj commented Aug 6, 2021

Good call @gotjosh, will open some new PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants