Use hjet/sdk fork of grafana-tools/sdk #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now, can reopen if this issue surfaces again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
go.modto use a fork of grafana-tools/sdk.The Grafana dashboard schema changes frequently and there are often type mismatches which can take weeks/months to get merged in to the upstream library. By using this fork,
grafana analysefunctionality won't get blocked and I can quickly update structs as needed so dashboard processing doesn't break. Since this dependency gets updated quite infrequently anyways, I can sync from upstream into the fork as needed and we can easily get rid of the fork at some point down the road.I don't think we want that repo under grafana/sdk as we are not "officially" maintaining it.
Also ran a
go mod vendorandgo mod tidy