Move analyse command logic to pkg, and export it #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed as a module in other projects
|
went through this quickly, but lgtm! i'm not an owner on this repo so would maybe get @gouthamve who also worked on this code to +1 it |
|
@gouthamve for context: this is to generate metric allowlists as part of the agent config we hand to users when configuring integrations (specifically the k8s integration, which scrapes a large number of active series) also see https://github.com/grafana/cloud-onboarding/pull/607/ |
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
…sed as a module in other projects (grafana/cortex-tools#214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows external consumers to use the metrics analysis that was previously entirely encapsulated in the analyse commands.