Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew stage for goreleaser. #222

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Fix homebrew stage for goreleaser. #222

merged 1 commit into from
Nov 11, 2021

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Nov 11, 2021

With the addition of benchtool, the release process is broken:

homebrew tap formula
release failed after 113.62s error=one tap can handle only archive of an
OS/Arch combination. Consider using ids in the brew section

This is because the tap stage expects to only find archives for cortextool, but
now also finds them for benchtool. The fix is to limit the archives inspected
by the homebrew step to those actually required for the step.

With the addition of benchtool, the release process is broken:

    homebrew tap formula
    release failed after 113.62s error=one tap can handle only archive of an
    OS/Arch combination. Consider using ids in the brew section

This is because the tap stage expects to only find archives for cortextool, but
now also finds them for benchtool. The fix is to limit the archives inspected
by the homebrew step to those actually required for the step.
@stevesg stevesg marked this pull request as ready for review November 11, 2021 19:17
@stevesg stevesg requested a review from a team as a code owner November 11, 2021 19:17
Copy link
Collaborator

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevesg stevesg merged commit 4d60651 into main Nov 11, 2021
@stevesg stevesg deleted the fix-releaser branch November 11, 2021 19:28
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
With the addition of benchtool, the release process is broken:

    homebrew tap formula
    release failed after 113.62s error=one tap can handle only archive of an
    OS/Arch combination. Consider using ids in the brew section

This is because the tap stage expects to only find archives for cortextool, but
now also finds them for benchtool. The fix is to limit the archives inspected
by the homebrew step to those actually required for the step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants