Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow authentication with bearer token or JWT token #233

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

goelankitt
Copy link
Contributor

The client at this point only supports basic authentication. This PR allows a bearer or JWT token to be used for authentication.

@goelankitt goelankitt requested a review from a team as a code owner January 12, 2022 15:45
pkg/client/client.go Outdated Show resolved Hide resolved
pkg/client/client.go Outdated Show resolved Hide resolved
Ankit Goel and others added 3 commits January 12, 2022 18:22
Co-authored-by: Goutham Veeramachaneni <gouthamve+github@gmail.com>
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gouthamve gouthamve merged commit feaf58b into grafana:main Jan 14, 2022
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
…afana#233)

* update container names to match the ones expected by cortex-mixin

Signed-off-by: Dan Constantinescu <dconstantinescu@blackberry.com>

* update changelog

Signed-off-by: Dan Constantinescu <dconstantinescu@blackberry.com>

* rollback nginx container name

Signed-off-by: Dan Constantinescu <dconstantinescu@blackberry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants