Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remote-read): return err instead of nil #235

Closed
wants to merge 1 commit into from

Conversation

Dentrax
Copy link

@Dentrax Dentrax commented Jan 18, 2022

Screen Shot 2022-01-18 at 17 40 19

Actual Behavior

$ cortextool remote-read stats --address http://10.10.10.10:30090 --selector '{__name__=~"istio.*"}' --remote-read-path /api/v1/read --log.level debug --read-timeout 60s

INFO[0000] log level set to debug
INFO[0000] Created remote read client using endpoint 'http://10.10.10.10:30090/api/v1/read'
INFO[0000] Querying time from=2022-01-18T16:01:52+03:00 to=2022-01-18T17:01:52+03:00 with selector={__name__=~"istio.*"}

$ echo $?
0

Expected Behavior

INFO[0000] log level set to debug                       
INFO[0000] Created remote read client using endpoint 'http://10.10.10.10:30090/api/v1/read' 
INFO[0000] Querying time from=2022-01-18T16:39:20+03:00 to=2022-01-18T17:39:20+03:00 with selector={__name__=~"istio.*"} 
___2remote_read_stats: error: remote server http://10.10.10.10:30090/api/v1/read returned HTTP status 400 Bad Request: exceeded sample limit (50000000), try --help

Process finished with the exit code 1

@eminaktas @yasintahaerol

Signed-off-by: Furkan furkan.turkal@trendyol.com
Co-authored-by: Emin emin.aktas@trendyol.com
Co-authored-by: Yasin yasintaha.erol@trendyol.com

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Co-authored-by: Emin <emin.aktas@trendyol.com>
Co-authored-by: Yasin <yasintaha.erol@trendyol.com>
@Dentrax Dentrax requested a review from a team as a code owner January 18, 2022 14:40
@Dentrax
Copy link
Author

Dentrax commented Mar 1, 2022

Kind ping here 🤞 @gotjosh @gouthamve

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2022

CLA assistant check
All committers have signed the CLA.

@Dentrax
Copy link
Author

Dentrax commented Sep 26, 2022

Kindly ping again 🤞 @gotjosh @gouthamve

@aknuds1
Copy link
Contributor

aknuds1 commented Sep 26, 2022

cortextool is deprecated in favour of mimirtool. Is this bug still present in mimirtool?

@Dentrax
Copy link
Author

Dentrax commented Sep 26, 2022

cortextool is deprecated in favour of mimirtool. Is this bug still present in mimirtool?

Oh, didn't notice deprecation warning! Can you please make this repository achieved?

@Dentrax
Copy link
Author

Dentrax commented Sep 27, 2022

MOVED: grafana/mimir#3051

@Dentrax Dentrax closed this Sep 27, 2022
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
* Optionally pass cortex config as configmap.

Fixes grafana#235.

Signed-off-by: Josh Carp <jm.carp@gmail.com>

* rework format for guide section

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

* fix config volume name

Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

Co-authored-by: ShuzZzle <niclas.schad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants