fix(analyse_prometheus): store errors instead of exit #237
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes grafana#236 Signed-off-by: Furkan <furkan.turkal@trendyol.com> Co-authored-by: Emin <emin.aktas@trendyol.com> Co-authored-by: Yasin <yasintaha.erol@trendyol.com> Co-authored-by: Batuhan <batuhan.apaydin@trendyol.com>
|
Kind ping here 🤞 @gotjosh @gouthamve |
|
|
|
Any ideas?
|
@Dentrax something's changed with our CLA setup. Asking within the org, to try and find out. |
|
@Dentrax it's due to an issue we're having with CLA Assistant :/ Our administrator is in the process of trying to resolve it. |
|
@Dentrax the CLA Assistant issue should be solved now, but it might still be slow in picking up your having signed (it is for me). |
|
Kind ping 🤞 @aknuds1 |
This was referenced Sep 27, 2022
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: ShuzZzle <niclas.schad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236
Make sure you have
metrics-in-grafana.jsonfile in the directory.Signed-off-by: Furkan furkan.turkal@trendyol.com
Co-authored-by: Emin emin.aktas@trendyol.com
Co-authored-by: Yasin yasintaha.erol@trendyol.com
Co-authored-by: Batuhan batuhan.apaydin@trendyol.com