blockscopy: log min and max time when skipping a block because of min duration filter #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… duration filter Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Aug 10, 2022
| @@ -226,7 +226,10 @@ func copyBlocks(ctx context.Context, cfg config, logger log.Logger, m *metrics) | |||
|
|
|||
| blockDuration := time.Millisecond * time.Duration(meta.MaxTime-meta.MinTime) | |||
| if blockDuration < cfg.minBlockDuration { | |||
| level.Debug(logger).Log("msg", "skipping block, block duration is smaller than minimum duration", "blockDuration", blockDuration, "minimumDuration", cfg.minBlockDuration) | |||
| minTime := time.Unix(0, meta.MinTime*int64(time.Millisecond)).UTC() | |||
There was a problem hiding this comment.
In newer Go version (I believe 1.17 and later) there is time.UnixMilli() that can be used.
There was a problem hiding this comment.
Right, but this project requirement is go 1.16. I would keep the upgrade separated.
|
Lint failure is unrelated. Will look into it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to use the blockscopy tool shortly, and I would like to log the min and max time when skipping a block because of the min duration filter.