Upgrade golang from 1.16 to 1.18 #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
colega
approved these changes
Aug 10, 2022
pstibrany
approved these changes
Aug 10, 2022
|
You'll need to upgrade golangci-lint, at least to 1.45 iirc. |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
This is not as easy as it looks. We need to upgrade a bunch of dependencies (see 712e105) but then cortex and dskit conflicts on the registration of the metric by Since we have However, this currently not a priority for me, so I'm going to close this PR and leave it just as a reference for the future. |
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
grafana#258) * - Fixed hardcoding of containerSecurityContext in Ingester statefulset - Brought setting of containerSecurityContext for the Ingester statefulset inline with other components configuration Signed-off-by: Ryan Woods <n4monitoring@node4.co.uk> * Removed hard coding of ingester securityContext Signed-off-by: Ryan Woods <n4monitoring@node4.co.uk> * add containerSecurityContext back to ingester pod container Signed-off-by: ShuzZzle <niclas.schad@gmail.com> * fix securityContext for ingester sts Signed-off-by: ShuzZzle <niclas.schad@gmail.com> Co-authored-by: Ryan Woods <n4monitoring@node4.co.uk> Co-authored-by: ShuzZzle <niclas.schad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm upgrading golang from 1.16 to 1.18. I've tested Dockerfile changes manually building all images running
make benchtool-image cortextool-image chunktool-image logtool-image e2ealerting-image push-e2ealerting-image blockscopy-image.