Add min/max time filter to blockscopy and change min duration default to 0 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 0 Signed-off-by: Marco Pracucci <marco@pracucci.com>
jhesketh
reviewed
Sep 27, 2022
We don't have tests for this tool. Ideally yes, but for many tools we don't have tests. |
56quarters
approved these changes
Sep 27, 2022
cmd/blockscopy/main.go
Outdated
| @@ -50,7 +52,9 @@ type config struct { | |||
| func (c *config) RegisterFlags(f *flag.FlagSet) { | |||
| f.StringVar(&c.sourceBucket, "source-bucket", "", "Source GCS bucket with blocks.") | |||
| f.StringVar(&c.destBucket, "destination-bucket", "", "Destination GCS bucket with blocks.") | |||
| f.DurationVar(&c.minBlockDuration, "min-block-duration", 24*time.Hour, "If non-zero, ignore blocks that cover block range smaller than this.") | |||
| f.DurationVar(&c.minBlockDuration, "min-block-duration", 0, "If non-zero, ignore blocks that cover block range smaller than this.") | |||
| f.Var(&c.minTime, "min-time", "If set, only blocks with MinTime >= this value are copied.") | |||
There was a problem hiding this comment.
Can you add an example of the expected format for these?
There was a problem hiding this comment.
Good idea. Done in: ce4619c
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
Lint fails because of the old go version required. I'm going to merge cause I will move this tool to Mimir repo. |
friedrichg
pushed a commit
to cortexproject/cortex-tools
that referenced
this pull request
Aug 1, 2023
Signed-off-by: Josh Carp <jm.carp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running a migration between two Grafana Mimir clusters and using the
blockscopytool to copy blocks. I've done some changes toblockscopyto support me, which I would like to upstream in this PR: