Ned's very WIP proposal for the API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artych
reviewed
Jun 28, 2021
built_in_fields.go
Outdated
| sourceGetter, err := callback(i) | ||
| if err == nil { | ||
| f.source = sourceGetter.GetSource() | ||
| if f.source != nil { |
There was a problem hiding this comment.
Is f.source is the latest source intentionally? May be to call it f.latestSource then?
There was a problem hiding this comment.
Hmm true, but I'm not sure which is clearer though 😕 My thinking was that this is the source that actually produced the value at dest after the consolidation. While latestSource also means the same think, it can also be confused with the top-level source (e.g. CLI flags), since it was tried last, even when it didn't return an actual value.
This will allow us to have CLI flags, I think...
This is temporarily done via the pflag library, though it's a very poor fit for our use case
Since we're "driving" the parsing in manual, we get the quotes and have to strip them
This is a prototype of how we can have a completely custom field with type-safe defaults and JSON unmarshalling, at the cost of referencing the destination multiple times...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very, very far from final, but it's an expansion on the ad-hoc proposal I sent in Slack, together with the rough requirements in and a basic TODO proposal the README.