Binding refactoring #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies value source implementations even further. Now they need to only work with int64, uint64 and float64 numbers, without any concern for bit sizes. Validation that smaller numbers can fit into the used smaller native types on the users' side is ensured by the frontends (e.g. NewInt8Field()).
This opens the way for injecting other types of value bindings, e.g. typed callbacks and validators.
This huge commit cleans up the interface types and makes them much more composable at the cost of minimal complexity increase of the sources. It also shifts the responsibility for Field value consolidation from the individual fields to the Manager and ManagedField.
This way they will automatically be initialized by the Manager, the user can't forget to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will probably be easier to read this commit by commit... 馃槄
The biggest change is that now we now have a clear difference in the
Binding(the callback that reads some source (or other) value and saves it to theDestination) and theBinder(the thing that creates theBinding). Array and number bindings are now also very similar to the other simpler bindings 馃帀 ThebitSizechecking is now only done on the frontend side, sources are no longer concerned with it (because they don't need to be) 馃帀I still want to tweak things things (potentially how default values are handled) and add more fields (esp. if I can reduce the boilerplate), so I may push a few more commits here... 馃槄