Custom Types #4
Closed
Custom Types #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to have CLI flags, I think...
This is temporarily done via the pflag library, though it's a very poor fit for our use case
Since we're "driving" the parsing in manual, we get the quotes and have to strip them
This is a prototype of how we can have a completely custom field with type-safe defaults and JSON unmarshalling, at the cost of referencing the destination multiple times...
WIP proposal 2, with very basic (and ugly) CLI flag support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I don't like from the latest API's iteration is the requirement to re-declare the type into the
Tomethod. It's repetition and it opens to have a mismatch between types.I tried to implement a solution to remove it and re-use the already passed type in the first argument. I know, it requires using
interface{}and type checking that is not optimal.