Basic types extension #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artych
commented
Jun 30, 2021
na--
reviewed
Jul 1, 2021
built_in_fields.go
Outdated
| } else if !errors.Is(ErrorMissing, err) { | ||
| continue | ||
| } | ||
| _, ok := err.(*BindNameMissingError) |
There was a problem hiding this comment.
In general, you shouldn't type cast errors directly, use errors.As() instead. See https://blog.golang.org/go1.13-errors
na--
reviewed
Jul 1, 2021
errors.go
Outdated
| var ErrorMissing = errors.New("field is missing in config source") //TODO: improve | ||
|
|
||
| type BindNameMissingError struct { | ||
| Func string // the failing function (like BindIntValueTo) |
There was a problem hiding this comment.
I am not sure we need the Func name here. If these errors ever reach the user (e.g. when something is required), they won't care about it anyway.
fix [fix] fix
na--
reviewed
Jul 2, 2021
na--
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status for int(), uint(), float(*):
env vars
[x?] json
flags: