Add unified number parsing functions in sources #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
commented
Jul 1, 2021
| if err != nil { | ||
| return err | ||
| func (cb *cliBinding) BindIntValue() func(bitSize int) (int64, error) { | ||
| if cb.position > 0 { |
There was a problem hiding this comment.
Couldn't find a nice way to avoid this repetition with pflag 😞
There was a problem hiding this comment.
My PR is changing that part so I will take care of it
artych
approved these changes
Jul 1, 2021
codebien
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preserves the completely type-safe "frontends" (i.e.
Fieldconstructors likeNewInt64Field(dest *int64, ...)), but makes the job of implementing aSourcemuch simpler. By using the biggest types, we don't need to implement a method for every single base Go number type (int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64, byte, float32, float64), instead just 3 (int64, uint64, float64) and some extra validation.