Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags parser #9

Merged
merged 8 commits into from
Jul 2, 2021
Merged

Flags parser #9

merged 8 commits into from
Jul 2, 2021

Conversation

codebien
Copy link
Collaborator

@codebien codebien commented Jul 1, 2021

No description provided.

@codebien codebien force-pushed the flag branch 2 times, most recently from f86c161 to be7eeca Compare July 2, 2021 16:30
@codebien codebien marked this pull request as ready for review July 2, 2021 16:31
na--
na-- approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 not sure if we're handling all of the possible corner cases with the flags, but we can iterate on those when we find the issues or when we have a broader test suite

@na-- na-- merged commit def6ece into main Jul 2, 2021
@na-- na-- deleted the flag branch July 2, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebien @na--