Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add org_id attribute to provider configuration #24

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

patst
Copy link
Contributor

@patst patst commented Apr 3, 2023

Description of your changes

Fixes #23

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Built it locally and created a folder with this providerconfig secret:

{
  "auth": "admin:superSecret",
  "url": "https://<mygrafanaurl>/",
  "org_id": "8"
}

Before the change the folder was always created in the main org. After my change it is created in the org with id 8.

Refs: grafana#23
Signed-off-by: patst <patrick.steinig@googlemail.com>
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@julienduchesne julienduchesne removed their request for review April 10, 2023 22:56
@julienduchesne
Copy link
Member

org_id will be deprecated as a provider-level option eventually but it doesn't hurt to add it in the meantime

@julienduchesne julienduchesne self-requested a review April 10, 2023 22:57
@julienduchesne julienduchesne merged commit 30fd9e2 into grafana:main Apr 12, 2023
6 checks passed
@patst patst deleted the fix/org-id-providerconfig branch September 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrgId cannot be set in provider config secret
3 participants