Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change targetType to kind #11

Closed
sdboyer opened this issue Aug 17, 2021 · 0 comments · Fixed by #16
Closed

Change targetType to kind #11

sdboyer opened this issue Aug 17, 2021 · 0 comments · Fixed by #16
Assignees
@ying-jeanne
Labels
component/generator kind/feature New feature or request
Projects
Grafana Backend (DO NOT USE!)

Comments

@sdboyer
Copy link
Contributor

sdboyer commented Aug 17, 2021

The targetType annotation is unnecessarily wordy, as well as misleading. kind would be better:

Foo: string @cuetsy(kind="interface")

kind is maybe not entirely right either. But it at least makes it clear we're not talking about types, but a higher-order concept.

We can retain legacy support for targetType if we want. Not a big deal.
@sdboyer sdboyer added component/generator kind/feature New feature or request labels Aug 17, 2021
@ying-jeanne ying-jeanne mentioned this issue Aug 23, 2021
Merged
@ying-jeanne ying-jeanne self-assigned this Aug 23, 2021
@ying-jeanne ying-jeanne linked a pull request Aug 23, 2021 that will close this issue
change attribute name from targetType to kind #16
Merged
@ying-jeanne ying-jeanne added this to To do in Grafana Backend (DO NOT USE!) via automation Aug 30, 2021
@ying-jeanne ying-jeanne added this to the 8.2.0 milestone Aug 30, 2021
@ying-jeanne ying-jeanne added this to To do in Grafana Backend (DO NOT USE!) via automation Aug 30, 2021
@ying-jeanne ying-jeanne moved this from To do to Done in Grafana Backend (DO NOT USE!) Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ying-jeanne ying-jeanne

Labels
component/generator kind/feature New feature or request
Projects
No open projects
Grafana Backend (DO NOT USE!)
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change attribute name from targetType to kind ying-jeanne/cuetsy
2 participants
@sdboyer @ying-jeanne