change attribute name from targetType to kind #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Aug 24, 2021
encoder/generator.go
Outdated
| attrEnumDefault = "enumDefault" | ||
| ) | ||
|
|
||
| var attrTarget = [...]string{"kind", "targetType"} |
There was a problem hiding this comment.
Meh. i know i said we could do this, but actually looking at the implementation, it seems silly to try to attain backwards compatibility here. This is an easy fix in the only place we know cuetsy to really exist - grafana/grafana.
So let's only support "kind"
There was a problem hiding this comment.
I was thinking that we might have to update all cue files there :), might be painful for now. ok let's keep it simple.
sdboyer
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix issue #11