Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/x/💩 #45

Merged
merged 1 commit into from
Jan 7, 2022
Merged

s/x/💩 #45

merged 1 commit into from
Jan 7, 2022

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Jan 7, 2022

🤷‍♂️

@sh0rez
s/x/💩
ebec69c 
🤷‍♂️
@sh0rez sh0rez requested a review from sdboyer January 7, 2022 15:35
@sdboyer
Copy link
Contributor

sdboyer commented Jan 7, 2022

yes please, yes please

@sdboyer sdboyer merged commit 485eef9 into main Jan 7, 2022
@sdboyer sdboyer deleted the 🤷‍♂️ branch January 7, 2022 15:35
@sdboyer
Copy link
Contributor

sdboyer commented Jan 7, 2022 •
edited

For anyone looking in from the outside/not in on the joke, this change just reflects the confusion we currently feel about how we got to the point of emitting an x in what feels like a random spot over the organic growth of this library.

We're working on a refactor. In the meantime, 💩 is no less incorrect than x where it's showing up in the output TS, so it's a self-deprecating way of blowing off some steam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdboyer sdboyer Awaiting requested review from sdboyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sh0rez @sdboyer