Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing v0.1.3 with our current cue files and I saw the following:
was generating:
with 0.1.3:
And its not right.
The issue came because
GraphPanel
andHeatmapPanel
are structs with data like:These structs are detected as maps, their kind is
cue.TopKind
and we setunknown
. So if we skip them, we can generate the proper value without losing information.Note: I back
any
as default in TopKind kind. When we detect an empty{...}
the writer is going to printResult<string, unknown>
like it was doing before.