Allow override values in child #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/grafana/schematization-and-as-code-project/issues/59
When a child overrides parent value, instead of put the new value, we were putting the type instead.
This is happening because we have a disjunction in this case and we aren't able to find the reference of this type. For that, we need to iterate a level more to see if its overwriting this value.
The overriding struct is a BottomKind with two elements inside, but it has the same structure than the fields with default values (
#AType & "a"). The difference between them is thecue.OrOpoperator that we can skip.Note: When you set an invalid override value, it doesn't write anything in TS file.
Also I added the path in the logs because its easier to identify what was wrong.