gen: Introduce generic import mapping #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spinillos this should be quite useful, and is in support of a larger goal scenes folks have for schemas |
|
We can put all of this logic inside a new |
|
not sure what this failure with |
spinillos
approved these changes
Mar 14, 2023
|
glad we're passing, but definitely need some tests on this first. there are weird cases to be checked here depending on whether/how the input is unified, and properties of the root instance being looked up |
sdboyer
commented
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces actual support for doing import mapping natively in cuetsy.
It's a little awkward and definitely needs some tests, but the new
cue.Value.Buildinstance()method introduced in a recent release of CUE makes all the difference here. Knowing that there is hugely helpful.This will end up allowing us to have imports with core kinds - which i'd swear we had an issue for, but i can't find it now.