Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null types generation #94

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix null types generation #94

merged 1 commit into from
Apr 4, 2023

Conversation

spinillos
Copy link
Member

Fixes: #79

It fixes null types in schemas.

I detected that a several things could reach cue.NullKind, so doing an inspection of the schemas, the easiest way to evaluate the nulls is the single case. The rest of cases can be evaluated in the next case and its why the fallthrough.

@spinillos spinillos requested a review from sdboyer April 3, 2023 08:29
sdboyer
sdboyer approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, we have a bunch of veneers that exist solely to add nulls. As preferable as it would be to just eliminate the nulls in the first place, this is better than having to backhack it in in the veneers

@sdboyer sdboyer merged commit 0bfb025 into main Apr 4, 2023
@sdboyer sdboyer deleted the allow-null-types branch April 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdboyer sdboyer sdboyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null types are unsupported
2 participants
@spinillos @sdboyer