Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shorthand structs #98

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Fix shorthand structs #98

merged 4 commits into from
Apr 11, 2023

Conversation

spinillos
Copy link
Member

For any reason, cue api doesn't find the attributes when we are using shorthands. To fix that, we need to cast the cue.Value into ast.Field and find the missing attributes.

@spinillos spinillos requested a review from sdboyer April 10, 2023 10:25
@sdboyer
Copy link
Contributor

sdboyer commented Apr 11, 2023

IMO this is worth filing a bug upstream against CUE

sdboyer
sdboyer approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just need to reroll given other merges

analyze.go Show resolved Hide resolved
@spinillos spinillos merged commit 253499f into main Apr 11, 2023
@spinillos spinillos deleted the fix-shorthand-structs branch April 11, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdboyer sdboyer sdboyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spinillos @sdboyer